Update antibodyregistry to use API #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage ? 53.04%
=======================================
Files ? 176
Lines ? 11821
Branches ? 1834
=======================================
Hits ? 6271
Misses ? 5312
Partials ? 238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I know there are things to fix in terms of tests and formatting, which I will get back to, but I'm happy to get feedback on the implementation at this point. |
manselmi
reviewed
Mar 20, 2025
Co-authored-by: Mike Anselmi <[email protected]>
Contributor
Author
|
OK, I keep getting after about an hour when trying to get the full data. I might want to add some retry logic and/or caching of parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #369.
This PR updates antibodyregistry to use their API. The API requires login, which is now handled by
httpx. After a login sequence that uses personal login information, the API can be used to download all the data.The previous implementation of this API was broken by updates from the maintainers of the data.
Issue: Slow Download
The current implementation takes ~3 hours. We should consider running concurrent requests to speed this up if 3 hours is unacceptable.